chore: some optimizations

This commit is contained in:
2024-12-02 17:01:27 +00:00
parent dc97c2c498
commit da2c7ffcce
3 changed files with 38 additions and 21 deletions

View File

@@ -200,6 +200,20 @@ function BuildArgRow({
setIsEditing(false);
}, [argName, arg, onFinish]);
const onArgNameChange = useCallback(
(event: React.ChangeEvent<HTMLInputElement>) => {
setArgName(event.currentTarget.value);
},
[],
);
const onArgChange = useCallback(
(event: React.ChangeEvent<HTMLInputElement>) => {
setArg(event.currentTarget.value);
},
[],
);
return (
<>
<Input
@@ -207,18 +221,14 @@ function BuildArgRow({
disabled={!isEditing}
placeholder="Argument name"
value={argName}
onChange={(event) => {
setArgName(event.currentTarget.value);
}}
onChange={onArgNameChange}
/>
<Input
type="text"
disabled={!isEditing}
placeholder="Argument value"
value={arg}
onChange={(event) => {
setArg(event.currentTarget.value);
}}
onChange={onArgChange}
/>
<div className="flex flex-row">
{isEditing ? (

View File

@@ -21,6 +21,7 @@ import dayjs from "dayjs";
import { Pencil, Plus, Trash2 } from "lucide-react";
import { useDeleteTemplate, useTemplates } from "./api";
import { NewTemplateDialog } from "./new-template-dialog";
import React from "react";
function TemplatesDashboard() {
return (
@@ -30,26 +31,33 @@ function TemplatesDashboard() {
</aside>
<Page>
<PageHeader>Templates</PageHeader>
<Dialog>
<main>
<DialogTrigger asChild>
<div className="flex flex-row py-4">
<Button variant="secondary" size="sm">
<Plus /> New template
</Button>
</div>
</DialogTrigger>
<TemplateTable />
</main>
<NewTemplateDialog />
</Dialog>
<Main />
<Toaster />
</Page>
</SidebarProvider>
);
}
function TemplateTable() {
function Main() {
return (
<Dialog>
<main>
<DialogTrigger asChild>
<div className="flex flex-row py-4">
<Button variant="secondary" size="sm">
<Plus /> New template
</Button>
</div>
</DialogTrigger>
<TemplateTable />
</main>
<NewTemplateDialog />
</Dialog>
);
}
const TemplateTable = React.memo(_TemplateTable, () => true);
function _TemplateTable() {
const { data: templates, isLoading } = useTemplates();
const deleteTemplate = useDeleteTemplate();
const { toast } = useToast();

View File

@@ -58,7 +58,6 @@ function createTemplateEditorStore({
} catch (error) {
console.error(error);
if (isApiErrorResponse(error)) {
console.log("askdjskdjk");
set({ buildError: error });
}
} finally {