kennethnym/infinifi
1
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

I added a meow sound for cat and some fixed and added cursor for volume #7

Merged
DMZTdhruv merged 7 commits from main into main 2024-07-26 17:08:37 +01:00
Conversation 8 Commits 7 Files Changed 5 +51 -44
5 changed files with 51 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 11379f05c3 - Show all commits

2
web/index.html
View File

@@ -37,7 +37,7 @@
kennethnym commented 2024-07-25 12:34:17 +01:00 (Migrated from github.com)
Review
Copy Link

if u could revert the indent changes back to using tab that would be great. (biome doesn't support html at the moment)

if u could revert the indent changes back to using tab that would be great. (biome doesn't support html at the moment)
kennethnym commented 2024-07-25 12:34:17 +01:00 (Migrated from github.com)
Review
Copy Link

if u could revert the indent changes back to using tab that would be great. (biome doesn't support html at the moment)

if u could revert the indent changes back to using tab that would be great. (biome doesn't support html at the moment)
<footer>
<span>made by kennethnym &lt;3 ·&nbsp;</span>
<a target="_blank" href="https://github.com/kennethnym/infinifi">github</a>
kennethnym commented 2024-07-25 12:34:17 +01:00 (Migrated from github.com)
Review
Copy Link

if u could revert the indent changes back to using tab that would be great. (biome doesn't support html at the moment)

if u could revert the indent changes back to using tab that would be great. (biome doesn't support html at the moment)
<a target="_blank" rel="noopener noreferrer" href="https://github.com/kennethnym/infinifi">github</a>
kennethnym commented 2024-07-25 12:34:17 +01:00 (Migrated from github.com)
Review
Copy Link

if u could revert the indent changes back to using tab that would be great. (biome doesn't support html at the moment)

if u could revert the indent changes back to using tab that would be great. (biome doesn't support html at the moment)
</footer>
<canvas id="bg"></canvas>
kennethnym commented 2024-07-25 12:34:17 +01:00 (Migrated from github.com)
Review
Copy Link

if u could revert the indent changes back to using tab that would be great. (biome doesn't support html at the moment)

if u could revert the indent changes back to using tab that would be great. (biome doesn't support html at the moment)
kennethnym commented 2024-07-25 12:34:17 +01:00 (Migrated from github.com)
Review
Copy Link

if u could revert the indent changes back to using tab that would be great. (biome doesn't support html at the moment)

if u could revert the indent changes back to using tab that would be great. (biome doesn't support html at the moment)

5
web/script.js
View File

@@ -133,9 +133,10 @@ playBtn.onmousedown = () => {
);
};
catImg.addEventListener("mouseover", () => {
// Cat audio sound function
catImg.onmousedown = () => {
meowAudio.play();
});
};
playBtn.onclick = () => {
if (isPlaying) {

8
web/style.css
View File

@@ -26,7 +26,6 @@
html,
body {
width: 100%;
overflow: hidden;
}
body {
@@ -152,10 +151,6 @@ a {
display: flex;
kennethnym commented 2024-07-25 12:39:21 +01:00 (Migrated from github.com)
Review
Copy Link

i prefer the default cursor for the button as it aligns with how the operating system behaves. imo many websites got it wrong (github included) by using pointer cursor for buttons when it should be reserved for links!

i prefer the default cursor for the button as it aligns with how the operating system behaves. imo many websites got it wrong (github included) by using pointer cursor for buttons when it should be reserved for links!
}
.button-container .button {
cursor: pointer;
}
.volume-slider-container {
position: absolute;
top: 0;
@@ -179,7 +174,6 @@ a {
appearance: none;
border: 2px solid var(--text);
background-color: var(--base);
cursor: col-resize;
}
kennethnym commented 2024-07-25 12:40:54 +01:00 (Migrated from github.com)
Review
Copy Link

the operating system also uses default cursor for sliders, which is why i refrained from using col-resize.

the operating system also uses default cursor for sliders, which is why i refrained from using `col-resize`.
DMZTdhruv commented 2024-07-26 06:38:36 +01:00 (Migrated from github.com)
Review
Copy Link

my windows didn't showed so I thought of using that

my windows didn't showed so I thought of using that
input[type="range"]::-webkit-slider-runnable-track {
@@ -296,4 +290,4 @@ input[type="range"]::-ms-fill-upper {
.button:after {
opacity: 0.5;
}
}
}