I added a meow sound for cat and some fixed and added cursor for volume #7

2024-07-24T19:24:04+01:00

DMZTdhruv commented

2024-07-24 19:24:04 +01:00

(Migrated from github.com)

Fixed the cursor pointer glitch for button, earlier it wasn't showing now it does, and I also added a cursor for volume,
and I added one more cute thing, when you hover over the bottom cat it, the cat will play meow sound
I used mp3 because they are of less size compared wav, Wav server better for audio but I guess it is just meow so mp3 will be great

Hi I am sorry there is something wrong with my indentation I keep 2 tab spaces, I tried to change my tab spaces to match yours but still results in same, this is my first time contributing so my apologies, if possible keep a code format rules😄

**Fixed the cursor pointer glitch for button**, earlier it wasn't showing now it does, and I also **added a cursor for volume**, and I added one more cute thing, when you hover over the bottom cat it, the **cat will play meow sound** I used mp3 because they are of less size compared wav, Wav server better for audio but I guess it is just meow so mp3 will be great Hi I am sorry there is something wrong with my indentation I keep 2 tab spaces, I tried to change my tab spaces to match yours but still results in same, this is my first time contributing so my apologies, if possible keep a code format rules😄

😆 1

kennethnym commented

2024-07-24 21:01:14 +01:00

(Migrated from github.com)

omg this is such an adorable pr 😭😭😭😭😭😭
i think u forgot to upload the meow :3 audio though, can u upload it so that i can try it out? also, self closing tag isn't well supported in html5, so if u could revert those that'd be great!

omg this is such an adorable pr 😭😭😭😭😭😭 i think u forgot to upload the meow :3 audio though, can u upload it so that i can try it out? also, self closing tag isn't well supported in html5, so if u could revert those that'd be great!

kennethnym commented

2024-07-25 00:06:50 +01:00

(Migrated from github.com)

re ur commit about code format rules, i added biome.json to specify the code style i adhere to, u can install biome following the docs here.

re ur commit about code format rules, i added `biome.json` to specify the code style i adhere to, u can install biome following [the docs here](https://biomejs.dev/).

DMZTdhruv commented

2024-07-25 05:37:04 +01:00

(Migrated from github.com)

re ur commit about code format rules, i added biome.json to specify the code style i adhere to, u can install biome following the docs here.

okay okay sorry, wait i will fix that everything >v<

> re ur commit about code format rules, i added `biome.json` to specify the code style i adhere to, u can install biome following [the docs here](https://biomejs.dev/). okay okay sorry, wait i will fix that everything >v<

DMZTdhruv commented

2024-07-25 06:08:47 +01:00

(Migrated from github.com)

re ur commit about code format rules, i added biome.json to specify the code style i adhere to, u can install biome following the docs here.

hey so I did made the changes and I can see my most recent commit here too but
I am not sure if you can see it or not?

I did as you mentioned
Audio File Upload: I have uploaded the meow-audio file so you can try it out. It should now play correctly when hovering over the cat image.
Note: For this I had to remove *mp3 from .gitignore so make sure to see it, there wasn't a wav audio and for a small meow audio wav size would be too big

HTML Tag Changes: I have reverted the self-closing tags to be more compatible with HTML5 standards and for consistency with the rest of the project.

Code Format: I noticed you added a biome.json file to specify the code style rules. I have installed Biome and ensured the code followed the specified formatting rules.

> re ur commit about code format rules, i added `biome.json` to specify the code style i adhere to, u can install biome following [the docs here](https://biomejs.dev/). hey so I did made the changes and I can see my most recent commit here too but I am not sure if you can see it or not? ![Screenshot 2024-07-25 103401](https://github.com/user-attachments/assets/c8b8a4e7-294e-40d2-b78c-4ea131488df4) I did as you mentioned **Audio File Upload:** I have uploaded the meow-audio file so you can try it out. It should now play correctly when hovering over the cat image. **Note**: For this I had to remove *mp3 from .gitignore so make sure to see it, there wasn't a wav audio and for a small meow audio wav size would be too big **HTML Tag Changes**: I have reverted the self-closing tags to be more compatible with HTML5 standards and for consistency with the rest of the project. **Code Format:** I noticed you added a biome.json file to specify the code style rules. I have installed Biome and ensured the code followed the specified formatting rules.

kennethnym (Migrated from github.com) requested changes 2024-07-25 12:44:54 +01:00

kennethnym (Migrated from github.com) left a comment

thank u again for this adorable pr 🥹 i don't think i'm sold on the cursor changes though as it deviates from standard operating system behavior. but the meow is so cute!!!!

web/index.html