mirror of
https://github.com/get-drexa/drive.git
synced 2026-02-02 19:01:16 +00:00
kenneth
d0c2a21ffd
RenameNode was calling Resolve() which generated blob keys for directories that don't have blobs, causing 'key not found' errors. Added ResolveRenameOp to BlobKeyResolver interface: - FlatKeyResolver returns nil (UUIDs don't change on rename) - HierarchicalKeyResolver returns move op for files and directories This allows directory renames to work correctly with flat storage, and leverages os.Rename for atomic directory moves with hierarchical. Co-authored-by: Ona <no-reply@ona.com>
42 lines
1.6 KiB
Go
42 lines
1.6 KiB
Go
package virtualfs
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/get-drexa/drexa/internal/blob"
|
|
"github.com/google/uuid"
|
|
"github.com/uptrace/bun"
|
|
)
|
|
|
|
type BlobKeyResolver interface {
|
|
// ShouldPersistKey returns true if the resolved key should be stored in node.BlobKey.
|
|
// Flat keys (e.g. UUIDs) return true - key is generated once and stored.
|
|
// Hierarchical keys return false - key is derived from path each time.
|
|
ShouldPersistKey() bool
|
|
Resolve(ctx context.Context, db bun.IDB, node *Node) (blob.Key, error)
|
|
ResolveDeletionKeys(ctx context.Context, node *Node, allKeys []blob.Key) (*DeletionPlan, error)
|
|
|
|
// ResolveBulkMoveOps returns blob move operations for nodes being moved to a new parent.
|
|
// Returns ErrBulkMoveRequiresSameParent if nodes don't all share the same parent.
|
|
// Returns nil, nil if no blob moves are needed (e.g., flat key storage where keys are UUIDs).
|
|
ResolveBulkMoveOps(ctx context.Context, db bun.IDB, nodes []*Node, newParentID uuid.UUID) ([]BlobMoveOp, error)
|
|
|
|
// ResolveRenameOp returns the blob move operation needed when renaming a node.
|
|
// Returns nil, nil if no blob move is needed (e.g., flat key storage where keys are UUIDs).
|
|
// For hierarchical storage, returns a single move op for both files and directories
|
|
// (os.Rename handles directories atomically).
|
|
ResolveRenameOp(ctx context.Context, db bun.IDB, node *Node, newName string) (*BlobMoveOp, error)
|
|
}
|
|
|
|
type DeletionPlan struct {
|
|
Prefix blob.Key
|
|
Keys []blob.Key
|
|
}
|
|
|
|
// BlobMoveOp represents a blob move operation from OldKey to NewKey.
|
|
type BlobMoveOp struct {
|
|
Node *Node
|
|
OldKey blob.Key
|
|
NewKey blob.Key
|
|
}
|