From b8c46217f78298a4dc9559d570c81b09e2d0e066 Mon Sep 17 00:00:00 2001 From: kenneth Date: Sat, 8 Nov 2025 18:03:15 +0000 Subject: [PATCH] chore: remove debug console.logs and add error handling - Remove console.log statements from upload file dialog - Add onError handler to display error toasts - Update ErrorCode reference in use-file-drop Co-authored-by: Ona --- apps/drive-web/src/files/upload-file-dialog.tsx | 6 ++++-- apps/drive-web/src/files/use-file-drop.ts | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/apps/drive-web/src/files/upload-file-dialog.tsx b/apps/drive-web/src/files/upload-file-dialog.tsx index caa0b52..a2d81d0 100644 --- a/apps/drive-web/src/files/upload-file-dialog.tsx +++ b/apps/drive-web/src/files/upload-file-dialog.tsx @@ -1,5 +1,6 @@ import type { Doc } from "@fileone/convex/dataModel" import { mutationOptions } from "@tanstack/react-query" +import { ConvexError } from "convex/values" import { atom, useAtom, useAtomValue, useSetAtom, useStore } from "jotai" import { atomEffect } from "jotai-effect" import { atomWithMutation } from "jotai-tanstack-query" @@ -88,7 +89,6 @@ function useUploadFilesAtom({ ) }, }).catch((error) => { - console.log("error", error) store.set( fileUploadStatusAtomFamily(pickedFile.id), { @@ -130,6 +130,9 @@ function useUploadFilesAtom({ toast.success("All files uploaded successfully") } }, + onError: (error) => { + toast.error(formatError(error)) + }, }), [uploadFile, store.set], ) @@ -533,7 +536,6 @@ function PickedFileItem({ }) { const fileUploadAtom = fileUploadStatusAtomFamily(pickedFile.id) const fileUpload = useAtomValue(fileUploadAtom) - console.log("fileUpload", fileUpload) const { file, id } = pickedFile let statusIndicator: React.ReactNode diff --git a/apps/drive-web/src/files/use-file-drop.ts b/apps/drive-web/src/files/use-file-drop.ts index f2bee92..34c886f 100644 --- a/apps/drive-web/src/files/use-file-drop.ts +++ b/apps/drive-web/src/files/use-file-drop.ts @@ -54,7 +54,7 @@ export function useFileDrop({ errors: Err.ApplicationErrorData[] }) => { const conflictCount = errors.reduce((acc, error) => { - if (error.code === Err.Code.Conflict) { + if (error.code === Err.ErrorCode.Conflict) { return acc + 1 } return acc